Release 0.66.0 performance fixes #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
force-pushed
the
release-0.66.0-performance-fixes
branch
from
e5f1270
to
d48fede
Compare
|
Wow 🤩 |
I wouldn't get too excited. These are just the raw function benchmark numbers for specific functions. The overall validation speeds still aren't changing yet :( I'm hoping after a bunch of these, it will make a difference. |
TwitchBronBron
force-pushed
the
release-0.66.0-performance-fixes
branch
from
e515b66
to
7ad0db7
Compare
* Potentially solved Scope Linking slow down * Favor focused parent lookup instead of parse-time link --------- Co-authored-by: Bronley Plumb <[email protected]>
…/rokucommunity/brighterscript into release-0.66.0-performance-fixes
…#841) Co-authored-by: Bronley Plumb <[email protected]>
…842) * Better use of cache for getting symbol types * Adds space after function
…/rokucommunity/brighterscript into release-0.66.0-performance-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds many performance fixes to try and recover lost speed due to type tracking.
Overall improvement (to a large proprietary project):
v0.65.1release-0.66.0Here are the various improvements made in this PR:
optimize
util.getAllGottedGetPartsoptimize
util.getDottedGetPathoptimize
util.getAllDottedGetPartsAsStringgetAllDottedGetPartsgetAllDottedGetPartsoptimize
cache.getOrAddto callsuper.has()andsuper.get()instead ofthis.*which eliminates some prototype lookups.optimize scope.buildNamespaceLookup()